Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Deprecating set-output commands #376

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

GitHub Actions: Deprecating set-output commands #376

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33513a8
using env variable set to manage output
ChristianGeie Dec 6, 2024
e65ca0a
adding bash as shell explicit
ChristianGeie Dec 6, 2024
aaf47d6
remove all output env variables
ChristianGeie Dec 6, 2024
669e87b
adding needed id to step
ChristianGeie Dec 6, 2024
ffc4368
undo changes
ChristianGeie Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/build_and_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
name: "Build and Test"
on:
- pull_request
Expand Down Expand Up @@ -73,10 +73,13 @@ jobs:
name: images
path: /tmp
- name: Load images into kind cluster
shell: bash
run: |
kind load image-archive /tmp/k8s-sidecar.tar --name sidecar-testing
kind load image-archive /tmp/dummy-server.tar --name sidecar-testing
- name: Install Sidecar and Dummy Server
id: install_sidecar
shell: bash
run: |
wait_for_pod_ready() {
while [[ $(kubectl get pods $1 -o 'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != "True" ]]; do echo "waiting for pod '$1' to become ready..." && sleep 5; done
Expand All @@ -98,6 +101,8 @@ jobs:
wait_for_pod_ready "dummy-server-pod"

- name: Install Configmaps and Secrets
id: install_configmaps_and_secrets
shell: bash
run: |
wait_for_pod_log() {
while [[ $(kubectl logs $1 | grep $2) == "" ]]; do echo "waiting 5 more seconds for '$2' to appear in logs of pod '$1'..." && sleep 5; done
Expand All @@ -117,6 +122,7 @@ jobs:
# 10 more seconds after the last thing appeared in the logs.
sleep 10
- name: Retrieve pod logs
shell: bash
run: |
mkdir /tmp/logs
kubectl logs sidecar > /tmp/logs/sidecar.log
Expand Down
Loading