Fix codefactor warnings

kiwix · Jan 17, 2025 · f9e46f4 · f9e46f4
1 parent d2dc9e9
commit f9e46f4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/App/App_macOS.swift b/App/App_macOS.swift
@@ -75,9 +75,8 @@ struct Kiwix: App {
             CommandGroup(after: .textEditing) {
                 Button("Search") {
                     if let toolbar = NSApp.keyWindow?.toolbar,
-                       let search = toolbar.items.first(where: { $0.itemIdentifier.rawValue == "com.apple.SwiftUI.search" }) as? NSSearchToolbarItem {
-                        search.beginSearchInteraction()
-                    }
+                       let item = toolbar.items.first( where: { $0.itemIdentifier.rawValue == "com.apple.SwiftUI.search" } ),
+                       let search = item as? NSSearchToolbarItem { search.beginSearchInteraction() }
                 }.keyboardShortcut("f", modifiers: [.command, .shift])
             }
         }

diff --git a/Views/BrowserTab.swift b/Views/BrowserTab.swift
@@ -58,9 +58,7 @@ struct BrowserTab: View {
                 ArticleShortcutButtons(displayMode: .mainAndRandomArticle)
 
 #if os(macOS)
-                Button(action: {
-                    searchFocus = searchFocus ?? search.results.first?.id
-                }) {}
+                Button(action: { searchFocus = searchFocus ?? search.results.first?.id }, label: {})
                     .opacity(0)
                     .keyboardShortcut(.return, modifiers: [])
 #endif

diff --git a/Views/SearchResults.swift b/Views/SearchResults.swift
@@ -88,7 +88,7 @@ struct SearchResults: View {
                     .onMoveCommand { direction in
                         let results = viewModel.results
                         if let searchFocus = self.searchFocus,
-                           let index = results.firstIndex(where: {searchFocus == $0.id}){
+                           let index = results.firstIndex(where: {searchFocus == $0.id}) {
                             if direction == .up,
                                index > results.startIndex {
                                 let prev = results.index(before: index)
@@ -116,7 +116,7 @@ struct SearchResults: View {
         NotificationCenter.openURL(result.url)
     }
 
-    private struct SearchResultButton : View {
+    private struct SearchResultButton: View {
         @FocusState.Binding var searchFocus: Int?
         var searchText: String
         var result: SearchResult
@@ -139,7 +139,7 @@ struct SearchResults: View {
         }
     }
 
-    private struct SearchResultButtonBase : View {
+    private struct SearchResultButtonBase: View {
         var searchText: String
         var result: SearchResult
         var zimFile: ZimFile?