Add live activities for download progress #1058
Closed
+127
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kiwix#1037 Add Live Activities support for displaying download progress on the lock screen and in the Dynamic Island. * Import `ActivityKit` and create a new `DownloadActivityAttributes` struct in `App/App_iOS.swift`. * Update `Model/DownloadService.swift` to manage Live Activities during download progress changes. * Modify `Views/BuildingBlocks/DownloadTaskCell.swift` to include Live Activities updates. * Update `Views/Library/ZimFileDetail.swift` to handle Live Activities for download details. * Add Live Activities updates in `Views/Library/ZimFilesDownloads.swift`. * Add a new setting to enable or disable Live Activities in `Views/Settings/Settings.swift`. * Handle alerts for Live Activities in `Views/ViewModifiers/AlertHandler.swift`. * Add `Model/DownloadActivityAttributes.swift` to define the attributes for Live Activities. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/kiwix/kiwix-apple/issues/1037?shareId=XXXX-XXXX-XXXX-XXXX).
|
@plyght Thank you for your PR, we will review it, but might take a while considering we are now mostly in the Christmas break. |
@kelson42 All good! Have a wonderful Christmas! |
|
Thank you for your PR @plyght . By the first glance, it needs more work.
|
BPerlakiH
reviewed
Jan 2, 2025
| @@ -337,6 +346,11 @@ final class DownloadService: NSObject, URLSessionDelegate, URLSessionTaskDelegat | |||
| progress.updateFor(uuid: zimFileID, | |||
| downloaded: totalBytesWritten, | |||
| total: totalBytesExpectedToWrite) | |||
| // Update Live Activity | |||
| let progressPercentage = Double(totalBytesWritten) / Double(totalBytesExpectedToWrite) | |||
| let speed = Double(bytesWritten) / 1024.0 / 1024.0 // Convert to MB/s | |||
There was a problem hiding this comment.
This seems to be incorrect.
It has no notion of time, therefore it cannot represent speed, which is per second.
BPerlakiH
reviewed
Jan 2, 2025
| @@ -265,6 +252,7 @@ struct Settings: View { | |||
| SelectedLanaguageLabel() | |||
| }.disabled(library.state != .complete) | |||
| Toggle("library_settings.toggle.cellular".localized, isOn: $downloadUsingCellular) | |||
| Toggle("library_settings.toggle.live_activities".localized, isOn: $enableLiveActivities) | |||
There was a problem hiding this comment.
This seems to be a nice addition, but the value of it isn't read anywhere, so it's not turning anything on / off atm.
BPerlakiH
reviewed
Jan 2, 2025
| @@ -139,4 +130,14 @@ private struct RootView: UIViewControllerRepresentable { | |||
| func updateUIViewController(_ controller: SplitViewController, context: Context) { | |||
| } | |||
| } | |||
|
|
|||
| struct DownloadActivityAttributes: ActivityAttributes { | |||
There was a problem hiding this comment.
This struct is a duplicate.
|
Closing this PR for now, it requires more work, and a more throughout approach to handle cross platform, and iOS 16.1 availability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Add Live Activities support for displaying download progress on the lock screen and in the Dynamic Island.
ActivityKitand create a newDownloadActivityAttributesstruct inApp/App_iOS.swift.Model/DownloadService.swiftto manage Live Activities during download progress changes.Views/BuildingBlocks/DownloadTaskCell.swiftto include Live Activities updates.Views/Library/ZimFileDetail.swiftto handle Live Activities for download details.Views/Library/ZimFilesDownloads.swift.Views/Settings/Settings.swift.Views/ViewModifiers/AlertHandler.swift.Model/DownloadActivityAttributes.swiftto define the attributes for Live Activities.For more details, open the Copilot Workspace session.