[Don't merge]デコード結果をShift_JISに倒すように変更 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sassy 背景となる情報への参照と、確認方法の記載をお願いします。 |
|
こけているテストは、あらかじめ正解のわかっているQRコードを読ませてその結果を正解と比較するテストですね。 (もしも数あるレセコンの中でUTF-8をECIなしに出力してくるやつがいたら死ぬという話であるが…… |
|
@katoken-0215 背景のリンクはdescriptionに貼りました。 |
|
動作させないと変更が妥当かどうか分からないので、動作方法をお願いします。 |
|
@katoken-0215 あと非同期でこのやりとりやってると効率悪いので、 |
|
@sassy やりとりそうですね…。 ただやることが詰まっていて、今日はNSIPS Agentのタスクをまとめてしたいので、 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
力技でcharsetをShift_JISに指定
ECIは考慮する
とりあえずこれで運用してみる
(背景)
https://kakehashi.slack.com/archives/C027WUT7KJ9/p1626243991024000
https://kakehashi.slack.com/archives/C027WUT7KJ9/p1626424084071500
(気になり)
テストは失敗しているが、修正する必要ありか？