Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reactivating test_transaction_data_to_starknet_calldata #1443

Merged
merged 1 commit into from
Oct 10, 2024
Merged

reactivating test_transaction_data_to_starknet_calldata #1443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/models/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ mod tests {
use std::str::FromStr;

#[test]
#[ignore = "failing because of relayer change"]
fn test_transaction_data_to_starknet_calldata() {
// Define a sample signed transaction.
// Using https://sepolia.kakarotscan.org/tx/0x5be347c9eb86cf04b884c7e6f432c6daa2054b46c3c70c7d4536e4c009765abe
Expand All @@ -118,18 +117,22 @@ mod tests {

// Assert the length of calldata.
// We must adapt the check as we pack the calldata in 31-byte chunks.
assert_eq!(calldata.len(), (transaction.transaction.length() + 30) / 31 + 1 + 6);
assert_eq!(calldata.len(), 59);

// Assert the first 6 elements of calldata.
assert_eq!(
calldata[0..6],
calldata[0..10],
vec![
Felt::ONE,
*KAKAROT_ADDRESS,
*ETH_SEND_TRANSACTION,
Felt::ZERO,
Felt::from((transaction.transaction.length() + 30) / 31 + 1),
Felt::from((transaction.transaction.length() + 30) / 31 + 1),
Felt::ZERO, // OutsideExecution caller
Felt::ZERO, // OutsideExecution nonce
Felt::ZERO, // OutsideExecution execute_after
Felt::from(u32::MAX), // OutsideExecution execute_before
Felt::ONE, // call_array_len
*KAKAROT_ADDRESS, // CallArray to
*ETH_SEND_TRANSACTION, // CallArray selector
Felt::ZERO, // CallArray data_offset
Felt::from((transaction.transaction.length() + 30) / 31 + 1), // CallArray data_len
Felt::from((transaction.transaction.length() + 30) / 31 + 1), // CallArray calldata_len
]
);
}
Expand Down
Loading