Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WithOtherFields for TransactionReceipt #1455

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

tcoratger
Copy link
Collaborator

No description provided.

@Eikix
Copy link
Member

Eikix commented Oct 11, 2024

Test failing

@tcoratger
Copy link
Collaborator Author

Test failing

@Eikix It wasn't a code issue, it's our CI that's failing randomly right for a week or so now.

We'll have to look at this closely, but in anyway it wasn't the code because the fail that occurred had nothing to do with the added parts and relaunching the tests gives green light on the CI.

@greged93
Copy link
Collaborator

Could we try running the whole system locally with docker compose and checking that out of Cairo steps transactions are indexed correctly ?

@greged93
Copy link
Collaborator

Best would be a real test but this works too

@tcoratger
Copy link
Collaborator Author

@greg Good timing, just wrote an issue to track this properly #1457

@Eikix
Copy link
Member

Eikix commented Oct 12, 2024

Best would be a real test but this works too

i think writing a test for it is shorter than trying locally

@tcoratger
Copy link
Collaborator Author

@Eikix I think we can merge this to move forward and do the test in a follow up PR tomorrow as per #1457

@tcoratger
Copy link
Collaborator Author

@Eikix Can we merge this so that @eugypalu can move on with tests?

@greged93 greged93 merged commit cec43f8 into kkrt-labs:main Oct 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants