chore: monorepo #1456
Merged
chore: monorepo #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obatirou
commented
Oct 1, 2024
enitrat
reviewed
Oct 1, 2024
obatirou
commented
Oct 1, 2024
ClementWalter
requested changes
Oct 2, 2024
There was a problem hiding this comment.
I suggest that the monorepo is not
|--
|-- kakarot0
|-- kakarot-ssj
(just putting them all in the same repo, what for?)
but keep the current kakarot structure, ie at the root a cairozero and a cairo project
|--
|-- src
|-- cairo1
with a possible renaming (open to suggestion)
|--
|-- cairo_zero
|-- cairo
obatirou
force-pushed
the
monorepo
branch
3 times, most recently
from
ee2c6d2
to
3d49d39
Compare
ClementWalter
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1394
What is the new behavior?
This change is