Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev(scripts): split deployment concerns in multiple files #1495

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 10, 2024

Splits the deployment flow in multiple files. leverage the "lazy execution"


This change is Reviewable

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.8%. Comparing base (f7eacc8) to head (1ebfb5e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1495   +/-   ##
=====================================
  Coverage   61.8%   61.8%           
=====================================
  Files         44      44           
  Lines       8197    8197           
=====================================
  Hits        5069    5069           
  Misses      3128    3128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add separator # %% for each section as it's more convenient to run some part on jupyter when required

ClementWalter
ClementWalter previously approved these changes Oct 11, 2024
@enitrat enitrat merged commit 9c83960 into main Oct 11, 2024
16 checks passed
@enitrat enitrat deleted the dev/deploy-scripts branch October 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants