-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream example cores #2
Comments
Strömbergsson is easy to work with, a few remains to upstream support for but that should be quick. I'll note that we have made pull requests to Strigeus two repositories but they haven't been handled, seems abandoned. Unless we want to bother him personally, probably nothing to do about it |
Yeah. Sending a PR is about as much as we can do. |
Alright then! All done. Let's see how many of these that get merged by the maintainers |
The Salsa PR has been merged. Thanks for providing it! |
The blabla core is more problematic. The problem is that is being used when it basically is an initial, non working core. I do realize that I'm the one to blame since there is no info for the core about the status. I can merge the PR, but will add status to the README. The PR is now merged. Thanks for the PR! |
Thanks for letting us know @secworks . All the better then to not have a stale copy of a non-working core being copied around and instead point to your version that might be fixed eventually :) |
Hi! I copied the setup (core-file, .github flow subdir, dataf subdir) for the blabla core and adapted to a new core (gimli [0]) and watched the CI builds. One thing I see is this warning:
I guess something needs to be updated. What should I fix? [0] The gimli core: |
Listing where the examples came from and status of upstreaming
Remaining (checked box == in progress)
Deprecated
Done
The text was updated successfully, but these errors were encountered: