Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize ghaction #4

Merged
merged 2 commits into from
May 15, 2021
Merged

Generalize ghaction #4

merged 2 commits into from
May 15, 2021

Conversation

wallento
Copy link
Contributor

No description provided.

@olofk
Copy link
Owner

olofk commented May 13, 2021

Looks good but can't merge yet. We use point to the subservient openlane_runner in other repos so we need to detach them first

@wallento
Copy link
Contributor Author

It's also draft at the moment. Does not work (yet). Do you have an overview of where you are using it?

@olofk
Copy link
Owner

olofk commented May 13, 2021

This is probably a good start. klasnordmark/openlane-examples#2

@wallento wallento force-pushed the main branch 11 times, most recently from abd450a to 858edb1 Compare May 14, 2021 12:09
The GitHub FuseSoC action is revamped and able to run openlane
examples created by us (still needs more generalization).
@wallento
Copy link
Contributor Author

I restored the file. It is quite straight forward to add the logic to run the containerized runners from that script. But on the other hand we want to chase after its usages, right? Started with the first two PRs to fix it and will comment in the mentioned issue then.

@wallento wallento marked this pull request as ready for review May 14, 2021 18:53
@wallento
Copy link
Contributor Author

Ready now

@olofk
Copy link
Owner

olofk commented May 15, 2021

Cool! Let's go with this and we'll hunt the remaining users in time

@olofk olofk merged commit 6fcc2f8 into olofk:main May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants