[CHNL-15530] Message Bus Support #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-masseau
reviewed
Jan 2, 2025
| const supportedEventTypes = event.detail.eventTypes; | ||
| console.log('Supporting message types:', supportedEventTypes); | ||
|
|
||
| const messageBus = window['inAppFormsMessageBus']?.messageBus; |
There was a problem hiding this comment.
TIL you can use ? for optional chaining in JS nowadays
There was a problem hiding this comment.
Oof this is annoying, but this syntax may not be supported in an iOS webview on our minimum supported iOS version, ios 13, see
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining#browser_compatibility
|
@dan-peluso I've created a repo for the bridge js code, and I included the changes you have here. So this PR will get superceded by this one, adding the git submodule with the new repo. |
|
Closing this bc similar code will just live in fender. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly logic added to the bridge.js (which I am certainly in support of making a different repo so we can import the same file for every native client we have) to support listening for the bus to be created, and then listening for each of the messages and relaying to the kotlin webview client.
Check List
Changelog / Code Overview
Test Plan
Testing this requires some decent setup:
1 - get app running with onsite modules
2 - get fender running (using this branch) with onsite dependencies as well - should be able to publish a form in the webapp and then make it live
3 - change the HTML code to point to a local
:8080onsite instead of production, and make sure to run the following adb commands if you're running a network proxyadb reverse tcp:8080 tcp:8080adb reverse tcp:4001 tcp:4001You should now be able to see the locally created form from the android test app in the 'messaging' menu. Check the logs after loading and ensure that a
inAppFormsDataLoadedhas come through.Related Issues/Tickets
https://klaviyo.atlassian.net/browse/CHNL-15530