trimming white spaces in identifiers

klaviyo · Apr 10, 2024 · adff271 · adff271
1 parent 45ec195
commit adff271
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/Sources/KlaviyoSwift/KlaviyoState.swift b/Sources/KlaviyoSwift/KlaviyoState.swift
@@ -506,7 +506,7 @@ extension Profile {
 
 extension String {
     fileprivate func isNotEmptyOrSame(as state: String?, identifier: String) -> Bool {
-        let incoming = self
+        let incoming = trimmingCharacters(in: .whitespacesAndNewlines)
         if incoming.isEmpty || incoming == state {
             logDevWarning(for: identifier)
         }

diff --git a/Tests/KlaviyoSwiftTests/StateManagementEdgeCaseTests.swift b/Tests/KlaviyoSwiftTests/StateManagementEdgeCaseTests.swift
@@ -158,6 +158,13 @@ class StateManagementEdgeCaseTests: XCTestCase {
         _ = await store.send(.setEmail(""))
     }
 
+    func testSetEmailWithWhiteSpace() async throws {
+        let initialState = INITIALIZED_TEST_STATE()
+        let store = TestStore(initialState: initialState, reducer: KlaviyoReducer())
+
+        _ = await store.send(.setEmail("        "))
+    }
+
     // MARK: - Set External Id
 
     @MainActor
@@ -196,6 +203,13 @@ class StateManagementEdgeCaseTests: XCTestCase {
         _ = await store.send(.setExternalId(""))
     }
 
+    func testSetExternalIdWithWhiteSpaces() async throws {
+        let initialState = INITIALIZED_TEST_STATE()
+        let store = TestStore(initialState: initialState, reducer: KlaviyoReducer())
+
+        _ = await store.send(.setExternalId(""))
+    }
+
     // MARK: - Set Phone number
 
     @MainActor
@@ -233,6 +247,13 @@ class StateManagementEdgeCaseTests: XCTestCase {
         _ = await store.send(.setPhoneNumber(""))
     }
 
+    func testSetPhoneNumberWithWhiteSpaces() async throws {
+        let initialState = INITIALIZED_TEST_STATE()
+        let store = TestStore(initialState: initialState, reducer: KlaviyoReducer())
+
+        _ = await store.send(.setPhoneNumber(""))
+    }
+
     // MARK: - Set Push Token
 
     @MainActor