Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming white spaces in identifiers #171

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

ajaysubra
Copy link
Contributor

@ajaysubra ajaysubra commented Apr 10, 2024

Description

When testing noticed that if you added white space we would still be making a call to our APIs with that white space and then fail with a 400. Trimming white space now before comparing the identifiers to see if they are empty or same as what the SDK holds in state. If it's same we avoid the API call and the subsequent failure. Note that there is an exception to this, when setting a profile we will still make the network call but it won't fail since the identifier will not be included. This is because there is no dedup check for set profile calls.

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Supporting Materials

@ajaysubra ajaysubra requested a review from a team as a code owner April 10, 2024 16:06
@ajaysubra ajaysubra merged commit f447adf into master Apr 11, 2024
8 of 9 checks passed
@ajaysubra ajaysubra deleted the as/trim-whitespaces branch April 11, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants