Trimming white spaces in identifiers #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When testing noticed that if you added white space we would still be making a call to our APIs with that white space and then fail with a 400. Trimming white space now before comparing the identifiers to see if they are empty or same as what the SDK holds in state. If it's same we avoid the API call and the subsequent failure. Note that there is an exception to this, when setting a profile we will still make the network call but it won't fail since the identifier will not be included. This is because there is no dedup check for set profile calls.
Check List
Manual Test Plan
Supporting Materials