Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding privacy manifest to KlaviyoSwift and KlaviyoSwiftExtension #174

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

ajaysubra
Copy link
Contributor

@ajaysubra ajaysubra commented Apr 11, 2024

Description

Apple requires SDK to add a privacy manifest listing,

  1. If the SDK does tracking.
  2. If it does tracking, what domains does it use for that purpose
  3. What required reason APIs does the SDK use
  4. What data points does the SDK collect.

The privacy manifest we added here is a least common denominator of what the SDK does, if developers are doing anything in addition to this in their specific apps like gathering emails/phone numbers they need to listed in your applications privacy manifest.

Some material from Apple about this -

Privacy manifest files
Describing data use in privacy manifests
WWDC 23 session on this topic

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Tested this using our test app and this is how the report looks like -

image

Supporting Materials

Developers can do the same when releasing their apps using archive -

image

@evan-masseau evan-masseau marked this pull request as ready for review April 12, 2024 14:08
@evan-masseau evan-masseau requested a review from a team as a code owner April 12, 2024 14:08
Copy link
Contributor

@evan-masseau evan-masseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajaysubra ajaysubra merged commit 9a04ba2 into master Apr 12, 2024
8 of 9 checks passed
@ajaysubra ajaysubra deleted the as/chnl-7372-privacyinfo.xcprivacy branch April 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants