Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed missing profile properties #175

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fixed missing profile properties #175

merged 2 commits into from
Apr 18, 2024

Conversation

ajaysubra
Copy link
Contributor

Description

These got removed when I did some refactor in #169

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Supporting Materials

@ajaysubra ajaysubra requested a review from a team as a code owner April 17, 2024 17:38
@ajaysubra ajaysubra requested a review from kennyklaviyo April 17, 2024 17:38
@ajaysubra ajaysubra merged commit a3b822a into master Apr 18, 2024
8 of 9 checks passed
@ajaysubra ajaysubra deleted the as/fixing-missing-profile-props branch April 18, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordan-griffin jordan-griffin jordan-griffin approved these changes

@evan-masseau evan-masseau evan-masseau approved these changes

@kennyklaviyo kennyklaviyo Awaiting requested review from kennyklaviyo kennyklaviyo is a code owner automatically assigned from klaviyo/mobile-push-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajaysubra @evan-masseau @jordan-griffin