Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed privacy policy for klaviyo swift extension #176

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ajaysubra
Copy link
Contributor

Description

When testing noticed that there was an error reported when I generated the privacy report. This was because we included a privacy report for the extension but it doesn't need based on apple docs,

image

Mainly the section about,

Otherwise, include a privacy manifest file in your third-party SDK if it uses required reasons API, collects data about the person using apps that include the third-party SDK, enables the app to collect data about people using the app, or contacts tracking domains.

Since the extension doesn't do any of these we don't need to include. I initially had included it just to be safe and say that we don't track using this SDK but if you include it expects you to list the required items which made me revisit this.

The report w/ the error on the top and one w/o at the bottom.

image

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Supporting Materials

@ajaysubra ajaysubra requested a review from a team as a code owner April 18, 2024 16:36
@ajaysubra ajaysubra requested a review from evan-masseau April 18, 2024 16:36
@ajaysubra ajaysubra requested a review from kennyklaviyo April 18, 2024 16:47
@ajaysubra ajaysubra merged commit a111c13 into master Apr 18, 2024
8 of 9 checks passed
@ajaysubra ajaysubra deleted the as/privacy-policy-fix branch April 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants