Flush requests queue on opened push event #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaysubra
commented
Jun 4, 2024
| we don't miss any user engagement events. In all other cases we will flush the queue | ||
| using the flush intervals defined above in `StateManagementConstants` | ||
| */ | ||
| return event.metric.name == .OpenedPush ? .task { .flushQueue } : .none |
There was a problem hiding this comment.
This is the main change.
| @@ -501,7 +509,7 @@ class StateManagementTests: XCTestCase { | |||
| let initialState = INITILIZING_TEST_STATE() | |||
| let store = TestStore(initialState: initialState, reducer: KlaviyoReducer()) | |||
|
|
|||
| let event = Event(name: .OpenedPush) | |||
| let event = Event(name: .OpenedAppMetric) | |||
There was a problem hiding this comment.
change to non opened push event since it doesn't matter for this test which event we use.
| @@ -485,14 +485,22 @@ class StateManagementTests: XCTestCase { | |||
| // MARK: - Test enqueue event | |||
|
|
|||
| @MainActor | |||
| func testEnqueueEvent() async throws { | |||
| func testEnqueueEvents() async throws { | |||
There was a problem hiding this comment.
Updated this test to test all events and added an exception for opened push at the bottom.
ndurell
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to keep engagement metric as up to date as possible we want to try and flush the queue whenever an opened push event request is enqueued.
Check List
Manual Test Plan
Unit tests but also using a proxy -