Adding Klaviyo UI module to SPM and cocoapods #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaysubra
commented
Sep 12, 2024
| @@ -4,6 +4,7 @@ use_frameworks! | |||
| target 'CocoapodsExample' do | |||
| # update this to a actual version once KlaviyoCore is published | |||
| pod 'KlaviyoSwift', :path => '../../..' | |||
| pod 'KlaviyoUI', :path => '../../..' | |||
There was a problem hiding this comment.
added in klaviyo ui for testing
ajaysubra
commented
Sep 12, 2024
| @@ -14,8 +14,8 @@ | |||
| "kind" : "remoteSourceControl", | |||
| "location" : "https://github.com/klaviyo/klaviyo-swift-sdk", | |||
| "state" : { | |||
| "revision" : "bcfb37dac6d424a20ae8e77bbe5aafdb66e8228f", | |||
There was a problem hiding this comment.
updated to master since there were changes that were not present in earlier released version and this was causing a compiler issue.
ajaysubra
changed the title
|
NBD, but let's try and merge this after cutting a release tag. We can retroactively do that too if we are not able to get the release out in time. |
ab1470
approved these changes
Sep 13, 2024
ndurell
reviewed
Sep 16, 2024
|
|
||
| import XCTest | ||
|
|
||
| final class KlaviyoUITests: XCTestCase { |
There was a problem hiding this comment.
nah, I think SPM complains if there is nothing in a newly created package so just added something.
ndurell
approved these changes
Sep 16, 2024
evan-masseau
approved these changes
Sep 18, 2024
ajaysubra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding in
KlaviyoUImodule to both SPM and cocoapodsCheck List
Manual Test Plan
Going to test using the example app within the SDK.
Cocoapods -
SPM -
Supporting Materials