3.3.0 release revisions #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab1470
requested review from
evan-masseau,
ndurell and
ajaysubra
and removed request for
a team
evan-masseau
approved these changes
Sep 19, 2024
|
Hey @ab1470 I'm not seeing the updates to the migration guide as mentioned in the description. May be you are still working on it as I see the PR is in draft. |
ajaysubra
reviewed
Sep 19, 2024
ajaysubra
approved these changes
Sep 19, 2024
Yeah that's why I put it back into draft. Working on the guide now and will mark it as ready when I'm done |
…iyo-swift-sdk into rel/3.3.0-revisions # Conflicts: # MIGRATION_GUIDE.md
…iyo-swift-sdk into rel/3.3.0-revisions # Conflicts: # MIGRATION_GUIDE.md
…iyo-swift-sdk into rel/3.3.0-revisions
ajaysubra
reviewed
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the revised
EventNameenum cases alongside the old ones so that consumers of the 3.3.0 release can proactively update their code.This should be a non-breaking change for most users, but there's an edge case for any users who are
switching over theEventNameenum. This change will be breaking for them, although it is a quick fix. It will be documented in the migration guide.Check List