Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHNL-13246] add webview popup chrome #230

Closed
wants to merge 14 commits into from

Conversation

ab1470
Copy link
Contributor

@ab1470 ab1470 commented Oct 28, 2024

Description

This adds the "chrome" around the WebView that will be used for the IAM content. The new KlaviyoWebWrapperViewController wraps the KlaviyoWebViewController and adds an inset, drop shadow, background blur, and/or background tint. These styles can all be customized using the KlaviyoWebWrapperStyle struct.

This PR addresses CHNL-13246.

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Run the Xcode Preview within the KlaviyoWebWrapperViewController file and validate that the view looks and works as expected.

Supporting Materials

Here are some examples of what the KlaviyoWebWrapperViewController looks like with different styles applied:

Blurred backgroundTinted background
Screenshot 2024-10-28 at 13 15 33Screenshot 2024-10-28 at 13 15 48

@ab1470 ab1470 marked this pull request as ready for review October 28, 2024 18:42
@ab1470 ab1470 requested a review from a team as a code owner October 28, 2024 18:42
@ab1470 ab1470 force-pushed the ab/CHNL-13246/add-webview-popup-chrome branch from 8a39f10 to a776f21 Compare November 8, 2024 14:01
@ab1470
Copy link
Contributor Author

ab1470 commented Nov 8, 2024

Closing this as we've decided on a different approach for MVP. We can revisit this PR, if necessary, at a future date.

@ab1470 ab1470 closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant