Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHNL-13251] dismiss webview on border tap #232

Closed
wants to merge 12 commits into from

Conversation

ab1470
Copy link
Contributor

@ab1470 ab1470 commented Oct 29, 2024

Description

This PR adds a tap target on the IAM webview's background so that the user can dismiss the IAM when the tap on the background.

The code in this PR only adds the tap target; actually handling the dismissal will come in a later PR, after we've implemented the architecture for displaying the IAM within the host app.

This addresses CHNL-13251.

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Supporting Materials

This video shows the "tapped dismiss" message being printed to the console when the user taps on the background behind the web view.

Screen.Recording.2024-10-29.at.17.25.44.mov

@ab1470 ab1470 force-pushed the ab/CHNL-13251/dismiss-webview-on-border-tap branch from ebafef5 to c8e3038 Compare November 8, 2024 14:02
@ab1470
Copy link
Contributor Author

ab1470 commented Nov 8, 2024

Closing this PR as we've decided on a different approach for MVP. We can revisit this at a future date if necessary.

@ab1470 ab1470 closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant