Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHNL-12485: Update V3 API revisions #245

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CHNL-12485: Update V3 API revisions #245

wants to merge 3 commits into from

Conversation

belleklaviyo
Copy link
Contributor

Description

Update from 2023-07-15 to 2024-10-15.

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Testing will be lumped in with the testing of badge count work here.

Supporting Materials

https://developers.klaviyo.com/en/docs/changelog_

ndurell
ndurell approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ndurell ndurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this change to ensure this change didn't affect any of our requests?

@ajaysubra
Copy link
Contributor

Were you able to test this change to ensure this change didn't affect any of our requests?

@ndurell we met with Paul from DevX and identified that there are no breaking changes to the client APIs we use. However, the reason we are doing this now is so that we can lump it into testing with badge count.

@belleklaviyo belleklaviyo marked this pull request as ready for review December 20, 2024 21:56
@belleklaviyo belleklaviyo requested a review from a team as a code owner December 20, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaysubra ajaysubra ajaysubra approved these changes

@ndurell ndurell ndurell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belleklaviyo @ajaysubra @ndurell