Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): update ormbfile struct #150

Merged
merged 6 commits into from
Nov 30, 2020
Merged

feat(*): update ormbfile struct #150

merged 6 commits into from
Nov 30, 2020

Conversation

judgeeeeee
Copy link
Contributor

@judgeeeeee judgeeeeee commented Nov 22, 2020 •
edited
Loading

What this PR does / why we need it:

fix irregular:
Tensor.OpType json/yaml tags
Metadata.Hyperparameters
Tensor.DType json/yaml tags

update Signature.layers definition

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #149

Special notes for your reviewer:

/cc @your-reviewer

Release note:

change: ormbfile Tensor.OpType json/yaml tag from  'optype'  to  'opType' 
change: ormbfile Tensor.DType json/yaml tag from  'dtype'  to  'dType' 
change: ormbfile 'Metadata.Hyperparameters' to 'Metadata.HyperParameters'
change: ormbfile 'Hyperparameter' to 'HyperParameter'
change: ormbfile Signature.Layers from '[]layer{name string}' to 'map[string]int'
change: model format from MXNETParams to MXNetParams

@caicloud-bot caicloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2020
FogDong
FogDong reviewed Nov 22, 2020
View reviewed changes
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM /cc @simon-cj

FogDong
FogDong reviewed Nov 22, 2020
View reviewed changes
pkg/model/types.go Outdated
@@ -45,23 +45,19 @@ type Hyperparameter struct {
type Signature struct {
Inputs []Tensor `json:"inputs,omitempty" yaml:"inputs,omitempty"`
Outputs []Tensor `json:"outputs,omitempty" yaml:"outputs,omitempty"`
Layers []Layer `json:"layers,omitempty" yaml:"layers,omitempty"`
Layers map[string]int `json:"layers,omitempty" yaml:"layers,omitempty"`
}

type Tensor struct {
Name string `json:"name,omitempty" yaml:"name,omitempty"`
Size []int `json:"size,omitempty" yaml:"size,omitempty"`
DType string `json:"dtype,omitempty" yaml:"dtype,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DType string `json:"dtype,omitempty" yaml:"dtype,omitempty"`
DType string `json:"dType,omitempty" yaml:"dType,omitempty"`

@caicloud-bot caicloud-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2020
@FogDong
Copy link
Member

FogDong commented Nov 23, 2020

/hold

@caicloud-bot caicloud-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2020
@codeflitting
Copy link
Member

LGTM

@simon-cj
Copy link
Contributor

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simon-cj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 27, 2020
@caicloud-bot
Copy link

@judgeeeeee: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@judgeeeeee
Copy link
Contributor Author

@simon-cj PTAL

@simon-cj
Copy link
Contributor

/lgtm

@simon-cj
Copy link
Contributor

simon-cj commented Nov 30, 2020 •
edited
Loading

/hold cancel

@simon-cj simon-cj removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 30, 2020
@simon-cj
Copy link
Contributor

/lgtm

@caicloud-bot caicloud-bot merged commit 83c2b3f into kleveross:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FogDong FogDong FogDong left review comments

Assignees

@simon-cj simon-cj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@judgeeeeee @FogDong @codeflitting @simon-cj @caicloud-bot