Report all namespace access in SelfSubjectNamespaceAccessReview (#479)

Signed-off-by: Tamal Saha <[email protected]>
kmodules · Sep 11, 2024 · 0451a5c · 0451a5c
1 parent fa8ef48
commit 0451a5c
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 2 deletions.
diff --git a/apis/identity/v1alpha1/openapi_generated.go b/apis/identity/v1alpha1/openapi_generated.go
diff --git a/apis/identity/v1alpha1/selfsubjectnamespaceaccessreview.go b/apis/identity/v1alpha1/selfsubjectnamespaceaccessreview.go
@@ -64,8 +64,9 @@ type SelfSubjectNamespaceAccessReviewSpec struct {
 }
 
 type SubjectAccessNamespaceReviewStatus struct {
-	Namespaces []string            `json:"namespaces,omitempty"`
-	Projects   map[string][]string `json:"projects,omitempty"`
+	AllNamespaces bool                `json:"allNamespaces"`
+	Namespaces    []string            `json:"namespaces,omitempty"`
+	Projects      map[string][]string `json:"projects,omitempty"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

diff --git a/crds/identity.k8s.appscode.com_selfsubjectnamespaceaccessreviews.yaml b/crds/identity.k8s.appscode.com_selfsubjectnamespaceaccessreviews.yaml
@@ -96,6 +96,8 @@ spec:
             description: Status is filled in by the server and indicates whether the
               request is allowed or not
             properties:
+              allNamespaces:
+                type: boolean
               namespaces:
                 items:
                   type: string
@@ -106,6 +108,8 @@ spec:
                     type: string
                   type: array
                 type: object
+            required:
+            - allNamespaces
             type: object
         required:
         - spec

diff --git a/hub/resourceeditors/catalog.appscode.com/v1alpha1/clickhousebindings.yaml b/hub/resourceeditors/catalog.appscode.com/v1alpha1/clickhousebindings.yaml
@@ -15,3 +15,12 @@ spec:
     name: clickhousebindings
     scope: Namespaced
     version: v1alpha1
+  ui:
+    editor:
+      name: catalogappscodecom-clickhousebinding-editor
+      sourceRef:
+        apiGroup: source.toolkit.fluxcd.io
+        kind: HelmRepository
+        name: appscode-charts-oci
+      version: v0.5.0
+    enforceQuota: false