Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eventing kafka broke reviewers role #3319

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Add eventing kafka broke reviewers role #3319

merged 1 commit into from
Sep 12, 2023

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Sep 5, 2023

Proposed Changes

  • Add eventing-kafka-broker-reviewers role as reviewer to repository

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2023
@Cali0707
Copy link
Member Author

Cali0707 commented Sep 5, 2023

/cc @pierDipi @matzew

@knative-prow knative-prow bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 5, 2023
@pierDipi
Copy link
Member

pierDipi commented Sep 5, 2023

The alias doesn't exist yet

eventing-kafka-broker/OWNERS_ALIASES

Lines 48 to 51 in a605869

eventing-kafka-broker-approvers:
- aliok
- matzew
- pierDipi

should we create it first?

@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #3319 (0db6a9b) into main (662b268) will decrease coverage by 3.13%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3319      +/-   ##
============================================
- Coverage     61.66%   58.53%   -3.13%     
============================================
  Files           182       91      -91     
  Lines         12312     9216    -3096     
  Branches        268        0     -268     
============================================
- Hits           7592     5395    -2197     
+ Misses         4125     3394     -731     
+ Partials        595      427     -168
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 91 files with indirect coverage changes

@Cali0707
Copy link
Member Author

Cali0707 commented Sep 5, 2023

The alias doesn't exist yet

eventing-kafka-broker/OWNERS_ALIASES

Lines 48 to 51 in a605869

eventing-kafka-broker-approvers:
- aliok
- matzew
- pierDipi

should we create it first?

@pierDipi I think I tried to create it in knative/community#1428. Will that work or do I need to do something else as well?

@Cali0707
Copy link
Member Author

/retest

@Cali0707
Copy link
Member Author

/verify-owners

@knative-prow knative-prow bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 11, 2023
@Cali0707
Copy link
Member Author

@pierDipi the owners file is valid now :)

@Cali0707
Copy link
Member Author

/cc @creydr

@knative-prow knative-prow bot requested a review from creydr September 11, 2023 14:45
creydr
creydr approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the alias in https://github.com/knative-extensions/eventing-kafka-broker/pull/3327/files 🎉
/lgtm

@knative-prow
Copy link

knative-prow bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2023
@Cali0707
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit d8aff5d into knative-extensions:main Sep 12, 2023
29 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@matzew matzew Awaiting requested review from matzew

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cali0707 @pierDipi @creydr