-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eventing kafka broke reviewers role #3319
Add eventing kafka broke reviewers role #3319
Conversation
Signed-off-by: Calum Murray <[email protected]>
The alias doesn't exist yet eventing-kafka-broker/OWNERS_ALIASES Lines 48 to 51 in a605869
should we create it first? |
Codecov Report
@@ Coverage Diff @@
## main #3319 +/- ##
============================================
- Coverage 61.66% 58.53% -3.13%
============================================
Files 182 91 -91
Lines 12312 9216 -3096
Branches 268 0 -268
============================================
- Hits 7592 5395 -2197
+ Misses 4125 3394 -731
+ Partials 595 427 -168
Flags with carried forward coverage won't be shown. Click here to find out more. |
@pierDipi I think I tried to create it in knative/community#1428. Will that work or do I need to do something else as well? |
/retest |
/verify-owners |
@pierDipi the owners file is valid now :) |
/cc @creydr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got the alias in https://github.com/knative-extensions/eventing-kafka-broker/pull/3327/files 🎉
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
d8aff5d
into
knative-extensions:main
Proposed Changes
eventing-kafka-broker-reviewers
role as reviewer to repository