Customizable prefix for cloudevent extensions #4144
Draft
+35
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As brought up before in this issue #3992, a previous version of NodeJS
cloudevents
would throw an error for any extension > 20 chars in length.We are in a tough position to update this package for a large number of legacy services, so we were hoping you could consider a change like this for versions 1.14 and onward.
The code I have changed here is incomplete, but I wanted to check if this change would be allowable first.
Basically just adding a new env var "CE_METADATA_EXTENSION_PREFIX" to change the "knativekafka" part of the "knativekafkapartition" and "knativekafkaoffset" CE extensions.
Release Note
Docs