Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kind registry by default #490

Closed
wants to merge 3 commits into from

Conversation

prushh
Copy link

@prushh prushh commented Jan 27, 2024

Fixes knative/docs#5778

Changes

  • Upgrade .gitignore with .DS_Store entry
  • Remove --registry flag
  • Create local registry by default when choosing Kind

Copy link

knative-prow bot commented Jan 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prushh
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from psschwei and rhuss January 27, 2024 00:02
Copy link

knative-prow bot commented Jan 27, 2024

Welcome @prushh! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2024
Copy link

knative-prow bot commented Jan 27, 2024

Hi @prushh. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2024
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to changing the default to include the registry, but we need to provide a way to disable the registry for folks using podman (see discussion in #393).

Alternatively, we probably shouldn't be trying to connect to a registry if we aren't creating it, so it might be better to fix the install process so that we don't do that (for example here and here) EDIT: this was fixed in #498

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prushh
Copy link
Author

prushh commented Apr 19, 2024

Hi @psschwei, sorry for the late replay.
I see that you fixed the problem with #498, can I close this PR?

@psschwei psschwei closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A local registry is no longer created by default.
3 participants