-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create kind registry by default #490
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prushh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @prushh! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉 |
Hi @prushh. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to changing the default to include the registry, but we need to provide a way to disable the registry for folks using podman (see discussion in #393).
Alternatively, we probably shouldn't be trying to connect to a registry if we aren't creating it, so it might be better to fix the install process so that we don't do that (for example here and here) EDIT: this was fixed in #498
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes knative/docs#5778
Changes
--registry
flag