Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update my Company affiliation #1404

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Update my Company affiliation #1404

merged 2 commits into from
Jul 24, 2023

Conversation

upodroid
Copy link
Member

/cc @kvmware

@knative-prow knative-prow bot requested a review from krsna-m July 24, 2023 15:15
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Jul 24, 2023

/lgtm
/retest

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@upodroid
Copy link
Member Author

brb

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@upodroid
Copy link
Member Author

fixed

@krsna-m
Copy link
Contributor

krsna-m commented Jul 24, 2023

/lgtm

and congrats!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@upodroid
Copy link
Member Author

thanks, can you add /approve pls? (TOC hat)

@krsna-m
Copy link
Contributor

krsna-m commented Jul 24, 2023

/approve
TOC hat activated!

@knative-prow
Copy link

knative-prow bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@knative-prow knative-prow bot merged commit 2384a24 into main Jul 24, 2023
1 check passed
@dprotaso dprotaso deleted the upodroid-affiliation branch August 23, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upodroid @krsna-m