Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add creydr as eventing approver #1414

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Add creydr as eventing approver #1414

merged 1 commit into from
Aug 4, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 4, 2023

Adding myself as an eventing approver.

From ROLES.md:

Requirements

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi August 4, 2023 06:39
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2023
@creydr
Add creydr as eventing approver
eae16db 
Signed-off-by: Christoph Stäbler <[email protected]>
@creydr creydr force-pushed the add-creydr-as-eventing-approver branch from 51eca2a to eae16db Compare August 4, 2023 06:42
pierDipi
pierDipi approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the contributions!

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@pierDipi
Copy link
Member

pierDipi commented Aug 4, 2023

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team August 4, 2023 06:50
@krsna-m
Copy link
Contributor

krsna-m commented Aug 4, 2023

Congrats!

psschwei
psschwei reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

/approve
/hold
(just in case others want to comment)

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@psschwei
Copy link
Contributor

psschwei commented Aug 4, 2023

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
@knative-prow knative-prow bot merged commit f19e983 into knative:main Aug 4, 2023
2 checks passed
@aliok aliok mentioned this pull request Jan 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@pierDipi pierDipi pierDipi approved these changes

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@creydr @pierDipi @krsna-m @psschwei