Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename sandbox to extensions #1419

Merged
merged 3 commits into from
Aug 16, 2023
Merged

rename sandbox to extensions #1419

merged 3 commits into from
Aug 16, 2023

Conversation

davidhadas
Copy link
Contributor

manual renaming of sandbox to extensions

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 11, 2023
@davidhadas davidhadas changed the title renqme sandbox to extensions rename sandbox to extensions Aug 11, 2023
@dprotaso
Copy link
Member

/unassign @dprotaso @aliok

This requires a rebase and @knative/steering-committee to approve

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023
@lance
Copy link
Member

lance commented Aug 14, 2023

Assuming a rebase...
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@lance
Copy link
Member

lance commented Aug 14, 2023

/approve

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@lance
Copy link
Member

lance commented Aug 16, 2023

@davidhadas can you please rebase this? Thanks.

@davidhadas davidhadas closed this Aug 16, 2023
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2023
@davidhadas davidhadas reopened this Aug 16, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@knative-prow
Copy link

knative-prow bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@knative-prow-robot knative-prow-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 16, 2023
@knative-prow knative-prow bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2023
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2023
@psschwei psschwei mentioned this pull request Aug 16, 2023
Merged
@lance
Copy link
Member

lance commented Aug 16, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@knative-prow knative-prow bot merged commit 9360770 into knative:main Aug 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr Awaiting requested review from csantanapr

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidhadas @dprotaso @lance @knative-prow-robot