Use python 3.11 for peribolos check #1621
Conversation
knative-prow
bot
added
approved
peribolos/ci
Outdated
| @@ -0,0 +1 @@ | |||
| Thu Oct 10 15:01:07 CEST 2024 | |||
There was a problem hiding this comment.
Forcing an action run, should be removed before merge.
/hold
knative-prow
bot
added
the
do-not-merge/hold
dsimansk
changed the title
| - run: pip install strictyaml --break-system-packages | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.11" | ||
| - run: pip install strictyaml |
There was a problem hiding this comment.
It seems we can go with --break-system-packages or pin Python to a version that works without the flag. I don't know if there are any drawbacks with --break-system-packages, but it's one liner in a check we always can revisit.
There was a problem hiding this comment.
pipx doesn't work for libraries:
➜ community git:(pr/pipx-fix) pipx install strictyaml
No apps associated with package strictyaml or its dependencies. If you are attempting to install a library, pipx should not be used. Consider using pip or a similar tool instead.
peribolos/ci
Outdated
| @@ -0,0 +1 @@ | |||
| Thu Oct 10 15:10:16 CEST 2024 | |||
There was a problem hiding this comment.
Forcing an action run, should be removed in final version.
|
@dsimansk we went with the other approach, right? |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to knative/infra#530
/cc @skonto @ReToCode @upodroid