Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove me from rabbitmq-eventing maintainers #1624

Merged
merged 2 commits into from
Oct 23, 2024
+2 −6
Merged

Remove me from rabbitmq-eventing maintainers #1624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05e7438
Update knative-extensions-OWNERS_ALIASES
Zerpet Oct 23, 2024
2ae35ca
Fix peribolos check
dsimansk Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/peribolos-schema-validate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ jobs:
fetch-depth: 0
lfs: true
- uses: actions/setup-python@v5
with:
python-version: "3.11"
with:
python-version: "3.11"
- run: pip install strictyaml
- name: Validate knative.yaml
run: python3 peribolos/validate-schema.py peribolos/knative.yaml
Expand Down
1 change: 0 additions & 1 deletion peribolos/knative-extensions-OWNERS_ALIASES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ aliases:
- lberk
- matzew
eventing-rabbitmq-approvers:
- Zerpet
- ikavgo
- mkuratczyk
eventing-redis-approvers:
Expand Down
2 changes: 0 additions & 2 deletions peribolos/knative-extensions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ orgs:
- yijie-04
- yuvalif
- zainabhusain227
- Zerpet
- yuzisun
- zhanggbj
- zhaojizhuang
Expand Down Expand Up @@ -1038,7 +1037,6 @@ orgs:
members:
- ikavgo
- mkuratczyk
- Zerpet
eventing-redis Approvers:
description: Approver group for eventing-redis - to be used in CODEOWNERS file
privacy: closed
Expand Down
1 change: 0 additions & 1 deletion peribolos/knative.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ orgs:
- yuvalif
- yuzisun
- zainabhusain227
- Zerpet
Copy link
Contributor

@dsimansk dsimansk Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line will effectively remove you from Knative gh org, if that's also desired. Then, you want to do the same on knative-extensions.yaml. But that's solely on your decision AFAIK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is ok. I don't think I'll get time to contribute to this community any time soon 😔

- zhanggbj
- zhaojizhuang
- ZhiminXiang
Expand Down
Loading