-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Merge Redundant TLS & OIDC e2e Tests #8017
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prajjwalyd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @prajjwalyd! It looks like this is your first PR to knative/eventing 🎉 |
Hi @prajjwalyd. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @prajjwalyd thanks for starting on this! I think the idea here is to merge the code in the features which we are passing into env.Test(...)
, rather than calling env.Test
multiple times in the same parent test. Let me know if you have any questions, I'm happy to help!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8017 +/- ##
==========================================
+ Coverage 67.79% 67.92% +0.13%
==========================================
Files 363 367 +4
Lines 16899 17323 +424
==========================================
+ Hits 11456 11767 +311
- Misses 4735 4823 +88
- Partials 708 733 +25 ☔ View full report in Codecov by Sentry. |
This Pull Request is stale because it has been open for 90 days with |
Addresses #7638
Proposed Changes
TestParallelTLS
&TestParallelTwoBranchesWithOIDC
intoTestParallelTLSAndOIDC
TestPingSourceTLS
&TestPingSourceSendsEventsOIDC
intoTestPingSourceTLSAndOIDC
Pre-review Checklist
Release Note
Docs