-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence reconciler reads and watch the config-features configmap #8124
Conversation
Signed-off-by: Pierangelo Di Pilato <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8124 +/- ##
==========================================
- Coverage 67.88% 67.88% -0.01%
==========================================
Files 368 368
Lines 17554 17565 +11
==========================================
+ Hits 11917 11924 +7
- Misses 4891 4893 +2
- Partials 746 748 +2 ☔ View full report in Codecov by Sentry. |
/lgtm |
/cherry-pick release-1.15 |
/cherry-pick release-1.14 |
@Cali0707: #8124 failed to apply on top of branch "release-1.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Cali0707: new pull request created: #8179 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In the sequence reconciler
feature.FromContext(ctx)
always returns the default feature flags as the context is not populated with theConfigStore