Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JobSink to have ObservedGeneration in status #8168

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 20, 2024

Currently the JobSinks CRD does not have a field for the ObservedGeneration in its status, while having the duck.status:

duckv1.Status `json:",inline"`

which has this field:
https://github.com/knative/pkg/blob/89743d9bbf7cc691f156b945bb29f96989da4e03/apis/duck/v1/status_types.go#L42

This leads to the rekt jobsinks.IsReady() check to not succeed.

This PR addresses it and adds the field in the CRD.

@creydr creydr requested a review from pierDipi August 20, 2024 10:37
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (bf945f9) to head (37abd2b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #8168       +/-   ##
=========================================
+ Coverage      0   67.46%   +67.46%     
=========================================
  Files         0      371      +371     
  Lines         0    18001    +18001     
=========================================
+ Hits          0    12144    +12144     
- Misses        0     5085     +5085     
- Partials      0      772      +772     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
Copy link

knative-prow bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Aug 20, 2024

/test reconciler-tests

@knative-prow knative-prow bot merged commit 5fc4c0f into knative:main Aug 20, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants