Fix JobSink to have ObservedGeneration in status #8168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the JobSinks CRD does not have a field for the ObservedGeneration in its status, while having the duck.status:
eventing/pkg/apis/sinks/v1alpha1/job_sink_types.go
Line 63 in bf945f9
which has this field:
https://github.com/knative/pkg/blob/89743d9bbf7cc691f156b945bb29f96989da4e03/apis/duck/v1/status_types.go#L42
This leads to the rekt jobsinks.IsReady() check to not succeed.
This PR addresses it and adds the field in the CRD.