Split AuthZ e2e tests #8181
Merged
Split AuthZ e2e tests #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8181 +/- ##
==========================================
+ Coverage 67.48% 67.49% +0.01%
==========================================
Files 371 371
Lines 18032 18032
==========================================
+ Hits 12169 12171 +2
+ Misses 5084 5083 -1
+ Partials 779 778 -1 ☔ View full report in Codecov by Sentry. |
|
/test reconciler-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the authz e2e conformance tests, test all authz features. This includes also to respect the filters.
Anyhow not all AuthZ supporting implementations implement the full feature set yet. For example EKB should support basic AuthZ - but no filtering yet. Anyhow it would be great to already have the possibility to enable the AuthZ e2e tests.
This PR addresses it and splits the AuthZ e2e tests and thus allows more fine grained tests.