Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.16] Add observedGeneration in JobSink OpenAPI schema #8300

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[release-1.16] Add observedGeneration in JobSink OpenAPI schema #8300

merged 1 commit into from
Nov 4, 2024

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #8297

Add observedGeneration in JobSink OpenAPI schema

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 4, 2024
Merged
5 tasks
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2024
matzew
matzew approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2024
pierDipi
pierDipi approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.09%. Comparing base (6db9011) to head (95bc3c4).
Report is 1 commits behind head on release-1.16.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.16    #8300   +/-   ##
=============================================
  Coverage         65.09%   65.09%           
=============================================
  Files               359      359           
  Lines             22030    22030           
=============================================
  Hits              14341    14341           
  Misses             6937     6937           
  Partials            752      752

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member

pierDipi commented Nov 4, 2024

/retest

@knative-prow knative-prow bot merged commit d0c035b into knative:release-1.16 Nov 4, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@matzew matzew matzew approved these changes

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-prow-robot @pierDipi @matzew