Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: struct naming in instanced go http templates synced #2670

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Jan 23, 2025

match the struct MyFunction

Signed-off-by: David Fridrich <[email protected]>
Copy link

knative-prow bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and nainaz January 23, 2025 17:20
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
Signed-off-by: David Fridrich <[email protected]>
@gauron99 gauron99 changed the title fix: Method names should match the struct fix: struct naming in instanced go http templates synced Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (20a173a) to head (81cbc51).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
+ Coverage   64.16%   65.42%   +1.25%     
==========================================
  Files         130      130              
  Lines       15519    15519              
==========================================
+ Hits         9958    10153     +195     
+ Misses       4622     4389     -233     
- Partials      939      977      +38     
Flag Coverage Δ
e2e-test 35.80% <ø> (-0.06%) ⬇️
e2e-test-oncluster 34.38% <ø> (+1.50%) ⬆️
e2e-test-oncluster-runtime 28.65% <ø> (?)
e2e-test-runtime-go 26.44% <ø> (?)
e2e-test-runtime-node 25.84% <ø> (?)
e2e-test-runtime-python 25.84% <ø> (?)
e2e-test-runtime-quarkus 25.99% <ø> (?)
e2e-test-runtime-rust 24.92% <ø> (?)
e2e-test-runtime-springboot 24.98% <ø> (?)
e2e-test-runtime-typescript 25.95% <ø> (?)
integration-tests 51.93% <ø> (+2.25%) ⬆️
unit-tests 50.95% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant