first python program #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviadP
suggested changes
Nov 29, 2019
| @@ -0,0 +1,9 @@ | |||
| file_object =open("a.txt","r") | |||
There was a problem hiding this comment.
When opening file it is mandatory to close it when its no longer needed. you can use "close" method, but better implementation would be to use "with...open"
| @@ -0,0 +1,9 @@ | |||
| file_object =open("a.txt","r") | |||
| data=file_object.read().split() | |||
| dict = {} | |||
There was a problem hiding this comment.
do not use "dict" as variable name, and as general guideline - var names need to be clear and meaningful
| file_object =open("a.txt","r") | ||
| data=file_object.read().split() | ||
| dict = {} | ||
| for i in data: |
There was a problem hiding this comment.
again, in python we are not using 'i' as var name.
AviadP
reviewed
Nov 29, 2019
| @@ -0,0 +1,9 @@ | |||
| file_object =open("a.txt","r") | |||
There was a problem hiding this comment.
It is better to use full path instead of file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is our script @MayaGreenbaum
thanks @AviadP