minor #453 [ci] tag test as legacy due to deprecation notice

* [ci] tag test as legacy due to deprecation notice - can drop legacy annotations once guard authenticators are no longer used * [ci] explicit nullable type in fixture
knpuniversity · Sep 30, 2024 · ca2048e · ca2048e
1 parent ffc61ae
commit ca2048e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/tests/Client/ClientRegistryTest.php b/tests/Client/ClientRegistryTest.php
@@ -17,6 +17,10 @@
 
 class ClientRegistryTest extends TestCase
 {
+    /**
+     * @group legacy
+     * @legacy drop legacy group when no longer using guard authenticators
+     */
     public function testShouldKnowWhatServicesAreConfigured()
     {
         $mockServiceMap = [

diff --git a/tests/Security/Authenticator/SocialAuthenticatorTest.php b/tests/Security/Authenticator/SocialAuthenticatorTest.php
@@ -100,7 +100,7 @@ public function doFetchAccessToken(OAuth2Client $client)
         return $this->fetchAccessToken($client);
     }
 
-    public function start(Request $request, AuthenticationException $authException = null): Response
+    public function start(Request $request, ?AuthenticationException $authException = null): Response
     {
     }
     public function supports(Request $request): bool