WIP

knurling-rs · Oct 9, 2024 · 61251cf · 61251cf
1 parent 25b5179
commit 61251cf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/xtask/src/backcompat.rs b/xtask/src/backcompat.rs
@@ -73,10 +73,6 @@ pub fn test() {
     };
 
     for snapshot_test in all_snapshot_tests() {
-        if snapshot_test == "net" && rustc_is_msrv() {
-            continue;
-        }
-
         let feature = match snapshot_test {
             "alloc" => "alloc",
             "net" => "ip_in_core",

diff --git a/xtask/src/snapshot.rs b/xtask/src/snapshot.rs
@@ -28,15 +28,19 @@ pub(crate) fn all_snapshot_tests() -> Vec<&'static str> {
         "hints",
         "hints_inner",
         "dbg",
-        "net",
         "panic_info",
     ];
     const NIGHTLY_SNAPSHOT_TESTS: &[&str] = &["alloc"];
+    const POST_MSRV_SNAPSHOT_TESTS: &[&str] = &["net"];
 
     let mut tests = STABLE_SNAPSHOT_TESTS.to_vec();
     if rustc_is_nightly() {
         tests.extend(NIGHTLY_SNAPSHOT_TESTS);
     }
+    if !rustc_is_msrv() {
+        tests.extend(POST_MSRV_SNAPSHOT_TESTS);
+    }
+
     tests
 }
 
@@ -80,10 +84,6 @@ pub fn test_snapshot(overwrite: bool, snapshot: Option<Snapshot>) {
 
 fn test_all_snapshots(overwrite: bool) {
     for test in all_snapshot_tests() {
-        if test == "net" && rustc_is_msrv() {
-            continue;
-        }
-
         let features = match test {
             "alloc" => "alloc",
             "net" => "ip_in_core",