Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use django admin color variables so dark mode works #30

Merged
merged 2 commits into from
Jun 11, 2024
Merged

use django admin color variables so dark mode works #30

merged 2 commits into from
Jun 11, 2024

Conversation

eviljeff
Copy link
Collaborator

fixes #8
Screenshot 2024-06-10 105139

@eviljeff eviljeff requested a review from knyghty June 10, 2024 09:52
@coveralls
Copy link

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9446248925

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.833%
Totals Coverage Status
Change from base Build 9436961525: 0.0%
Covered Lines: 32
Relevant Lines: 42
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9446248925

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.833%
Totals Coverage Status
Change from base Build 9436961525: 0.0%
Covered Lines: 32
Relevant Lines: 42
💛 - Coveralls

knyghty
knyghty approved these changes Jun 11, 2024
View reviewed changes
Copy link
Owner

@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. I pushed an extra fix as Chrome doesn't seem to care about dark mode for dialogs.

@eviljeff eviljeff merged commit 5ef88d0 into main Jun 11, 2024
9 checks passed
@eviljeff eviljeff deleted the 8-dark-mode-css branch June 11, 2024 12:49
@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9465613482

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.833%
Totals Coverage Status
Change from base Build 9436961525: 0.0%
Covered Lines: 32
Relevant Lines: 42
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9465613482

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.833%
Totals Coverage Status
Change from base Build 9436961525: 0.0%
Covered Lines: 32
Relevant Lines: 42
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knyghty knyghty knyghty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dark mode styling
3 participants
@eviljeff @coveralls @knyghty