Fixes #15 - Adds ESLint #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erosselli
force-pushed
the
issue-15-add-linting
branch
from
88b3993 to
36a09cd
Compare
Pull Request Test Coverage Report for Build 9453404876Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9453404876Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9453419588Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9453419588Details
💛 - Coveralls |
erosselli
commented
Jun 10, 2024
|
I wasn't sure if we should add the linter check to the CI, I think it'd be cool to have it but I checked Django's CI config and didn't see it being run so wasn't sure if I should add it here or not |
knyghty
requested changes
Jun 11, 2024
erosselli
force-pushed
the
issue-15-add-linting
branch
from
36a09cd to
af5a152
Compare
Pull Request Test Coverage Report for Build 9468427083Details
💛 - Coveralls |
knyghty
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15 - Adds ESLint along with relevant
.eslintrcfile (copied from thedjangorepo so we have the same config).All the changes in the JS files are just the fixes so linter is passing.