Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: FairClassifier regularization and fit intercept #679

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

FBruzzesi
Copy link
Collaborator

Description

Addresses both problems presented in #674, namely:

  • Regularization implementation
  • Fit intercept not returning if false

Fixes #674

Opening as draft since the issue has not been discussed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (ruff)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

@FBruzzesi FBruzzesi marked this pull request as ready for review June 15, 2024 12:49
Copy link
Owner

@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FBruzzesi
Copy link
Collaborator Author

Merging main broke CI?! Confusion to the max! 🤔

@koaning
Copy link
Owner

koaning commented Jul 1, 2024

This might be related to polars v1.0.0 that came out today. Feels plausible looking at the error messages.

@FBruzzesi FBruzzesi merged commit 439c9c0 into main Jul 2, 2024
18 checks passed
@FBruzzesi FBruzzesi deleted the patch/fair-classifier branch July 2, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fairness regularization
2 participants