Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: ci/cd hotfix #683

Merged
merged 2 commits into from
Jul 1, 2024
Merged

patch: ci/cd hotfix #683

merged 2 commits into from
Jul 1, 2024

Conversation

FBruzzesi
Copy link
Collaborator

@FBruzzesi FBruzzesi commented Jun 26, 2024

Description

Attempt to fix #682.

  • It certainly fix the polars 1.0 related issue
  • It may fix the regression outlier test by exaggerating the outlier values

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (ruff)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

@@ -27,7 +27,7 @@ def test_X():
return np.array([[-4, 2], [-2, 0], [4, -6]])


@pytest.mark.parametrize("frame_func", [pd.DataFrame, pl.DataFrame])
@pytest.mark.parametrize("frame_func", [pd.DataFrame, lambda data: pl.DataFrame(data, strict=False)])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli any insight on how strict changed between v0.20.x and v1.0.0? The docs seem to be identical, yet behavior is different?!

@koaning koaning merged commit bc124dd into main Jul 1, 2024
18 checks passed
@FBruzzesi FBruzzesi deleted the patch/ci-cd-hotfix branch July 1, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CI/CD Failing
2 participants