Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: LowessRegression usage docstring #688

Merged
merged 2 commits into from
Jul 13, 2024
Merged

docs: LowessRegression usage docstring #688

merged 2 commits into from
Jul 13, 2024

Conversation

david26694
Copy link
Contributor

@david26694 david26694 commented Jul 13, 2024 •
edited
Loading

Hey @FBruzzesi , adding a docstring for LowessRegression. A change has been done in a test file automatically by ruff, let me know if you want me to revert it.

Description

Fixes #650

Type of change

Docs

Checklist:

  • My code follows the style guidelines (ruff)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

koaning
koaning approved these changes Jul 13, 2024
View reviewed changes
Copy link
Owner

@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, good to have. Thanks!

@koaning
Copy link
Owner

koaning commented Jul 13, 2024

I am running the tests to be safe, but this can be merged once it all looks green.

FBruzzesi
FBruzzesi reviewed Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I am late to the party, but left a comment :)

sklego/linear_model.py Outdated Show resolved Hide resolved
tests/test_meta/test_zero_inflated_regressor.py
Comment on lines -115 to +116
def test_no_predict_proba():

def test_no_predict_proba():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries about this

@FBruzzesi FBruzzesi changed the title add lowess example docs: LowessRegression usage docstring Jul 13, 2024
@FBruzzesi FBruzzesi merged commit 1d9ef4c into koaning:main Jul 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBruzzesi FBruzzesi FBruzzesi left review comments

@koaning koaning koaning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linear_model.LowessRegression
3 participants
@david26694 @koaning @FBruzzesi