Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added chip component #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Swappea
Copy link
Contributor

@Swappea Swappea commented Oct 27, 2024

Description

  • Chips are compact elements that represent an input or an action.

Copy link

netlify bot commented Oct 27, 2024

👷 Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 99ba32e

@jer3m01
Copy link
Member

jer3m01 commented Oct 28, 2024

Thanks for the interest and PR!

Chip component overlaps a lot with Badge (PR unmerged but already approved), we might want to add the onClick and closeable feature to it instead.

I'll think over it and get back to you.

@Swappea
Copy link
Contributor Author

Swappea commented Oct 29, 2024

Thanks for the interest and PR!

Chip component overlaps a lot with Badge (PR unmerged but already approved), we might want to add the onClick and closeable feature to it instead.

I'll think over it and get back to you.

Originally I thought badge component was supposed to be similar to notification badges we have in our OS. Chip components are normally used as things to filter out, tagging stuff, & many more and also commonly named as Chip. That's why decided to add this component.

I see what you mean though. I will also research further on my side.

Also do let me know if there any other components to which I can contribute which might be in your backlog to avoid duplicate work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants