-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RatingGroup component #516
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kobalte ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Saw the preview. Look like a quality component! |
@HBS999 Minor accessibility suggestion: The component does not display a border on focus, so it's difficult to know what item the keyboard is focused on. This isn't a great experience. Your preview: https://deploy-preview-516--kobalte.netlify.app/docs/core/components/rating-group Example of focus border: https://mui.com/material-ui/react-rating/ |
Hi Meng, I purposefully set the outline to none because it kind of ruins the aesthetic look of the examples. Having to see these outlines in the examples every time you focus a star does not look good IMO. Seeing the stars appearing/disappearing should be enough to know which one is focused. This is also what ARK UI does in their example. In any case it is a one line change if there is pushback for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This works perfectly on desktop; however, I can't click on mobile (Android FF).
Also left a few notes.
@jer3m01 Hi Jeremy,
I cant reproduce this. It works fine on my phone. Are you saying you cant click on any star at all? |
Try opening the preview with Chrome Devtools on mobile mode. Sometimes touch responses won't change the rating |
Thanks Meng! I was able to reproduce this with the devtools but weirdly not on my phone. I believe it should be fixed now. PTAL Jeremy, sorry about this! |
Closes #315