Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RatingGroup component #516

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

HBS999
Copy link
Contributor

@HBS999 HBS999 commented Nov 4, 2024

Closes #315

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for kobalte ready!

Name Link
🔨 Latest commit 1135ac2
🔍 Latest deploy log https://app.netlify.com/sites/kobalte/deploys/67335c37fe6eb2000898adeb
😎 Deploy Preview https://deploy-preview-516--kobalte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 71 (🔴 down 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@MengLinMaker
Copy link
Contributor

Saw the preview. Look like a quality component!

@MengLinMaker
Copy link
Contributor

@HBS999 Minor accessibility suggestion:

The component does not display a border on focus, so it's difficult to know what item the keyboard is focused on. This isn't a great experience.

Your preview: https://deploy-preview-516--kobalte.netlify.app/docs/core/components/rating-group

Example of focus border: https://mui.com/material-ui/react-rating/

@HBS999
Copy link
Contributor Author

HBS999 commented Nov 9, 2024

Hi Meng, I purposefully set the outline to none because it kind of ruins the aesthetic look of the examples. Having to see these outlines in the examples every time you focus a star does not look good IMO. Seeing the stars appearing/disappearing should be enough to know which one is focused. This is also what ARK UI does in their example. In any case it is a one line change if there is pushback for this.

Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This works perfectly on desktop; however, I can't click on mobile (Android FF).
Also left a few notes.

apps/docs/src/examples/rating-group.tsx Outdated Show resolved Hide resolved
apps/docs/src/routes/docs/core/components/rating-group.mdx Outdated Show resolved Hide resolved
apps/docs/src/routes/docs/core/components/rating-group.mdx Outdated Show resolved Hide resolved
@HBS999
Copy link
Contributor Author

HBS999 commented Nov 12, 2024

@jer3m01 Hi Jeremy,

This works perfectly on desktop; however, I can't click on mobile (Android FF).

I cant reproduce this. It works fine on my phone. Are you saying you cant click on any star at all?

@MengLinMaker
Copy link
Contributor

MengLinMaker commented Nov 12, 2024

This works perfectly on desktop; however, I can't click on mobile (Android FF).

I cant reproduce this. It works fine on my phone. Are you saying you cant click on any star at all?

Try opening the preview with Chrome Devtools on mobile mode.
I can replicate the issue.

Sometimes touch responses won't change the rating

@HBS999
Copy link
Contributor Author

HBS999 commented Nov 12, 2024

Thanks Meng! I was able to reproduce this with the devtools but weirdly not on my phone. I believe it should be fixed now. PTAL Jeremy, sorry about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] Rating
4 participants