Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PinInput component #522

Closed
wants to merge 1 commit into from
Closed

Conversation

HBS999
Copy link
Contributor

@HBS999 HBS999 commented Nov 6, 2024

This PR adds a new PinInput component.

Copy link

netlify bot commented Nov 6, 2024

👷 Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 94134e2

@jer3m01
Copy link
Member

jer3m01 commented Nov 6, 2024

Hey thanks for the PR, however PinInput already exists in corvu and I'm not currently interested in maintaining one in Kobalte.

@jer3m01 jer3m01 closed this Nov 6, 2024
@HBS999
Copy link
Contributor Author

HBS999 commented Nov 6, 2024

Hi, it is not the same. The one in Corvu is a simple OTP one. This one has more functionality, including different input modes (alphabetic, alphanumeric), masking the inputs, and the fact that you can supply your own pattern.

@GiyoMoon
Copy link
Member

GiyoMoon commented Nov 6, 2024

Hey, the corvu OTP Field has all the features that you mentioned. Different input modes and patterns can be configured with the pattern property on the <OtpField.Input /> component and masking inputs is easy as the slots are just visual components and it's up to the user to style them and whether they want to show values or mask them.

@HBS999
Copy link
Contributor Author

HBS999 commented Nov 6, 2024

Hi Jasmin, nice seeing you here! It’s my fault for skimming the docs quickly 🤦‍♂️! I apologize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants