Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): fix prop not working properly on hidden select input #538

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

royeden
Copy link
Contributor

@royeden royeden commented Dec 23, 2024

Hello!

I've noticed that <Select /> components don't honor the required attribute properly, so this PR assigns a value attribute (same one assigned to the select element) to the input inside of <HiddenSelect />.

I wanted to add a test for this issue but I ran into the pointer-events issue that makes you skip all the current Select tests.

Copy link

netlify bot commented Dec 23, 2024

👷 Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4e0c76a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant