fix(select): fix prop not working properly on hidden select input #538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've noticed that
<Select />
components don't honor therequired
attribute properly, so this PR assigns avalue
attribute (same one assigned to theselect
element) to theinput
inside of<HiddenSelect />
.I wanted to add a test for this issue but I ran into the
pointer-events
issue that makes you skip all the currentSelect
tests.